Subject: Re: sys/netipsec vs. (FreeBSD) #include
To: Jun-ichiro itojun Hagino <itojun@itojun.org>
From: Jonathan Stone <jonathan@dsg.stanford.edu>
List: tech-kern
Date: 03/16/2004 15:01:47
In message <20040316225737.7D5B73E@coconut.itojun.org>,

Jun-ichiro itojun Hagino writes:

>> As far as I can tell, the sole obstacle to configuring, compiling, and
>> linking both FAST_IPSEC (src/sys/netipsec) and `options INET6' is
>> three or four references to the FreeBSD version of a KAME header file,
>> sys/netinet6/ip6_ecn.h. That file does not exist in NetBSD-current;
>> intsead the functions ip6_ecn_ingress() and ip6_ecn_egress() are
>> defined in sys/netinet/ip_ecn.h, inside #ifdef INET6/#endif.
>
>	the change was made by freebsd guys with some reason unknown to us
>	(kame).  netbsd follows the code from kame.
>
>> Rather than dink a half-dozen more "#ifdef __FreeBSD__ " into the
>> fast-ipsec source, I'd prefer to move those two functions into
>> netinet6/ip6_ecn.h, and preserve the existing namespace by having
>> netinet/ip_ecn.h do
>> 
>> #ifdef INET6
>> #include <netinet6/ip6_ecn.h>
>> #endif
>> 
>> Comments? Or is it likely FreeBSD would buy back the newer(?)
>> NetBSD-style, unified header?
>
>	to make kame synchronization easier, freebsd would go back to ip_ecn.h
>	(and no ip6_ecn.h).

Possibly so, but that's beyond my control. Thats why I cc'ed Sam
Leffler (botched in the original message, fixed above).