Frederick Bruckman wrote:

> I posted patches a couple of weeks ago to enable high-speed mode
> (greater than 115200 bps) on the Cyberserial PCI serial and combo
> cards.
> 
> This is considerably simpler than my earlier attempt: all the
> high-speed clocks are enabled at attachment, so the com stuff doesn't
> even need to know about it. This seems to work fine from 300 bps to
> 230400 bps. (I can't easily test the 921600 bps speed.)
> 
>   ftp://ftp.netbsd.org/pub/NetBSD/misc/fredb/cyberserial.diff
> 
> A benefit, is that the 4- and 8-port cards also get supported. I
> originally avoided that, because the all the ports on the card share
> the clock mode bit, so permission to change the speed on on one port
> would give leverage to manipulate the others. That whole issue is
> avoided by using the fast clock for all the ports, all the time.
> 
> These cards are ubiquitious and inexpensive, so it'll be great to see
> these supported by NetBSD. Comments?

Looks ok at a glance.  My only question is why the pcireg_t
variables need to be volatile in write_siig10x_usrreg() and
write_siig20x_usrreg()?

Simon.
--
Simon Burge                            <simonb@wasabisystems.com>
NetBSD Support and Service:         http://www.wasabisystems.com/