Subject: Re: Error LED on Soekris net4501
To: Quentin Garnier <cube@NetBSD.org>
From: Jason Thorpe <firstname.lastname@example.org>
Date: 12/01/2003 09:00:40
On Dec 1, 2003, at 12:08 AM, Quentin Garnier wrote:
> I have a net4501 at home and I wrote a little driver for it. I plan on
> committing at least parts of the attached patch (not necessarily the
> way it is done), but I'd like a bit of input before.
> The patch introduces a new option, CPU_SOEKRIS, that affects the Elan
> SC520 chipset driver. It adds a new character device that allows
> to the MMCR and to control the LED. Then the MMCR can be just mmap'ed,
> there is actually nothing specific to the net4501 on that part.
I don't see the need to have a CPU_SOEKRIS option. All that does is
determine which of the GPIO pins controls the LED, right?
I think it would be much better if you defined a generic GPIO control
interface. It looks like what you have is a good start for that.
-- Jason R. Thorpe <email@example.com>