Matt Thomas wrote:
> >+
> >+               if (fdp == NULL) {
> >+ #ifdef DIAGNOSTIC
> >+                       printf("kpsignal1: fdp NULL, proc %d flags %x\n",
> >+                              p->p_pid, p->p_flag);
> >+ #endif
> >+                       return;
> >+               }
> 
> Looks good to me.  (but you might to move the entire if inside the #ifdef).

Perhaps make it KASSERT().

Jaromir 
-- 
Jaromir Dolecek <jdolecek@NetBSD.org>            http://www.NetBSD.cz/
-=- We should be mindful of the potential goal, but as the tantric    -=-
-=- Buddhist masters say, ``You may notice during meditation that you -=-
-=- sometimes levitate or glow.   Do not let this distract you.''     -=-