Subject: Re: F_SETOWN/TIOCGPGRP/FIOSETOWN handling
To: Jaromir Dolecek <jdolecek@netbsd.org>
From: Frank van der Linden <fvdl@netbsd.org>
List: tech-kern
Date: 09/13/2003 20:08:47
On Sat, Sep 13, 2003 at 07:59:04PM +0200, Jaromir Dolecek wrote:
> * FIOSETOWN ioctl is now passed down to file object, just like
>   TIOCSPGRP; the translation in generic code is removed
> * there are new fsetown(), fgetown(), fownsignal() which
>   handle the ioctls, setting of object's pgid and signal
>   delivery - callers pass pointer to place where the
>   process/group ID is stored, and don't interpret the value
>   in any way
> * special handling of sockets in generic code is removed,
>   the ioctls go down to soo_ioctl() and are handled there
> 
> This makes the handling totally opaque for leaf objects,
> making the code easier to read and less error prone.

That looks good to me. I remember seeing this and thinking that
the code was a bit ugly.. in 1995, I think.. glad that it's
being taken care of :-)

- Frank