Subject: MTD driver cleanup
To: None <tech-kern@netbsd.org>
From: Peter Bex <Peter.Bex@student.kun.nl>
List: tech-kern
Date: 07/01/2003 17:04:29
--k4f25fnPtRuIRUb3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello all,

I'd like to suggest that someone removes the debug message emitted by the m=
td
driver when it's time to release NetBSD 2.0.

When I created the driver, I put in a debugging message in mtd803.c, lines
463 through 465. This is certainly not something one would like in a produc=
tion
system. (The messages are quite numerous)
Problem is, I still do not know what to do with the code. I created this
driver quite 'blindly', since I am not really familiar with networking stuf=
f.
Should the code stay the same, or not? It simply ignores packets which are
too large right now. Is this correct behaviour?

The driver works, though, so I think just removing the lines should suffice.
But since the (excellent) motto of NetBSD is: ''It doesn't work unless it's
correct'', I would like to point it out to all of you. Perhaps someone who
knows more about network cards than I could have a look at the code, and
perhaps explain this all to me.

I've posted to tech-net (which seemed the correct list for this), but nobody
responded, that's why I am posting it here.

Regards,
Peter
--=20
http://www.student.kun.nl/peter.bex
--
"The process of preparing programs for a digital computer
 is especially attractive, not only because it can be economically
 and scientifically rewarding, but also because it can be an aesthetic
 experience much like composing poetry or music."
							-- Donald Knuth

--k4f25fnPtRuIRUb3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (NetBSD)

iD8DBQE/AaL9Lg33BXzVMqsRAnjjAKCstgj4Ut6+JzC2MCW5AG8YjeBz6wCgpFrp
LKIrRfyjdTFX0h40W7mAVk0=
=EaKB
-----END PGP SIGNATURE-----

--k4f25fnPtRuIRUb3--