Subject: Re: ktrace records now get lwp id
To: Darren Reed <email@example.com>
From: Jason Thorpe <firstname.lastname@example.org>
Date: 06/28/2003 10:08:07
On Saturday, June 28, 2003, at 07:28 AM, Darren Reed wrote:
> Without a doubt I've broken all the other architectures compiling some
> drivers for which I apologise in advance but *I* can only do so much.
> The changes required to get these changes to work are going to be more
> manual than tricky. Typically replacing 'struct proc *' with a
> 'struct lwp *', maybe adding a l_proc here or there is what's required,
> along with updating function prototypes.
This is unacceptable. You have the ability to cross-compile nearly
every NetBSD platform, and you should have done so and fixed up the
problems before checking in this patch.
Also, who reviewed your final patch? I seem to recall there were some
issues with the previous version, and I didn't see an updated version
posted for review.
-- Jason R. Thorpe <email@example.com>