Subject: Re: L_SA tweaks
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Stephan Uphoff <ups@stups.com>
List: tech-kern
Date: 06/21/2003 11:08:21
Hi,
YAMAMOTO Takashi wrote:
> hi,
>
> is following patch correct?
>
> - since sa_newcachelwp() can sleep, turn L_SA off while calling it.
> - don't set L_SA again in sa_upcall_userret(). i guess it is an intent of
> rev.1.14.
The patch looks good and should prevent a few crashes.
However more is needed to protect a LWP then resetting/setting the L_SA.
The function sa_vp_repossess() has to block until it can grab an unprotected
LWP.
I am currently looking how to fix some resource shortage conditions
and should have a patch tomorrow that squashes a few more bugs.
Stephan