Subject: Re: genfs_getpages and MAX_READ_AHEAD
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
From: Andrey Petrov <petrov@netbsd.org>
List: tech-kern
Date: 06/11/2003 04:18:24
On Wed, Jun 11, 2003 at 10:36:09AM +0900, YAMAMOTO Takashi wrote:
> currently, genfs_getpages has a limit of number of pages.
> it's annoying because a caller should consider filesystem's block size
> to avoid assertion failure.
> 
> how about following patch?
> although using alloca here is ...yucky,
> there're already variable-sized arrays around.
> 

Could you give more details on why it's needed. Is that easy
to bump on that limitation?

In this patch you're replacing fixed-size array and assert on
alloca, which is more dangerous. malloc/free would be safer
but they cost more.

	Andrey