Subject: Re: ksyms patches.
To: None <firstname.lastname@example.org>
From: Jason Thorpe <email@example.com>
Date: 04/21/2003 08:41:37
On Monday, April 21, 2003, at 07:01 AM, <firstname.lastname@example.org> wrote:
And now for comments on the code :-)
In addsymtab(), I think, in fact, the shstrtab is loaded ... see
db_elf.c for how the .symtab and .strtab sections are linked up. I
think you'll want to duplicate that algorithm.
In general, it would be nice if locking were in place in this code.
Once less thing to fix later :-) I don't think that's a barrier to
this code being checked in, though ... mostly a "would be nice" :-)
What's the deal with NKSYMS? I'd say if kern_ksyms.c is built at all
that /dev/ksyms should be mandatory.
Other than the (pretty minor :-) comments above, this looks great!
Thanks a ton for doing this (this is also going to make embedded
systems a LOT happier :-)
-- Jason R. Thorpe <email@example.com>