Subject: Re: disk block number printing
To: <>
From: David Laight <>
List: tech-kern
Date: 04/13/2003 08:55:28
On Sun, Apr 13, 2003 at 08:19:33AM +0100, David Laight wrote:
> On Sun, Apr 13, 2003 at 09:14:30AM +1000, Darren Reed wrote:
> > In sys/kern/subr_disk.c, diskerr() uses %d to display block numbers.
> > 
> > For block numbers > 2^32, the output is not going to be correct, but
> > if I look at daddr_t, it may not always be int64_t.

Actually the numbers wouldn't be correct for values < 2^32 either :-)

> true... 'tis bust, well spotted.
> I'll fix it!

Done for 64bit daddr_t, I think all the kernels are built that way.
If not then the build will now fail.

I couldn't (quickly) work out a pre-processer test for the size
of daddr_t - in order to set the correct type in:
#define PRIdaddr PRId64


David Laight: