Subject: Re: Possible serious bug in NetBSD-1.6.1_RC2
To: None <tech-kern@netbsd.org>
From: Christos Zoulas <christos@zoulas.com>
List: tech-kern
Date: 04/10/2003 14:28:18
In article <200304100657.h3A6vQY21997@lothlorien.nfbcal.org>,
Brian Buhrow <buhrow@lothlorien.nfbcal.org> wrote:
>	Hello.  Following up on my own post, I'd like to amend my description
>of the problem.  Whenever the machine panics in pmap_change_attrs() it is
>always as a result of being called from genfs_putpages in
>/usr/src/sys/miscfs/genfs/genfs_vnops.c:1167.
>Since there was a report of someone seeing this panic on the sparc port, it
>seems like maybe there is a problem in the genfs_vnops.c file.
>
>	while I was writing this, I looked again at the genfs_vnops.c file,
>and think I might see the trouble.  Can anyone tell me why the following
>patch to genfs_vnops.c might not be a good idea?  I see all other
>references to pmap_clear_xxx() functions are protected by
>uvm_lock_pageq() and uvm_unlock_pageq() calls.  
>
>	I'll try this patch, but I'm still interested to know if folks think
>this is a bad idea for some reason.

No, looks like a good idea to me.

christos