Darren Reed <darrenr@reed.wattle.id.au> writes:

> In some email I received from Nathan J. Williams, sie wrote:
>> 

>> -#ifdef KTRACE
>>  	if (KTRPOINT(p, KTR_SYSRET)) {
>>  		KERNEL_PROC_LOCK(l);
>> -		ktrsysret(p, SYS_fork, 0, 0);
>> +		ktrsysret(l, SYS_fork, 0, 0);
>>  		KERNEL_PROC_UNLOCK(l);
>>  	}
>>  #endif
>> 
>> Seems wrong.
>
> Is there something wrong with this besides it being for SYS_fork ?
> I realise this "seems wrong" but not much else can be done here :(
> The process gets fork()'d, but the fork happens on a thread.

I think Nathan is trying to point out its wrong to remove #ifdef KTRACE.

Love