Subject: Heads up: I'm about to change the fo_ioctl 'data' to void *.
To: None <firstname.lastname@example.org>
From: David Laight <email@example.com>
Date: 03/21/2003 20:43:41
I'm about to change the fo_ioctl and fo_fcntl prototypes (in file.h)
so that the 'data' argument is 'void *' instead of 'caddr_t'.
The motivation is to avoid a load load lines wrapping in a different fix.
I hope I've found everywhere they get used, the i386, sparc and sparc64
kernels build in my tree. Userspace shouldn't be affected.
It is possible I've missed something lurking in code I don't compile.
The changed files will be:
The diff is a bit large, but can be found at:
I took the opportunity to delete some (caddr_t) casts from copyin/out
call in some of the files, as well as from the ioctl/fcntl calls.
I spotted a couple of bugs in sunos32_ioctl.c:
- case _IOW('t', 101, int): the args of copyin were reversed (line 489)
- I think there are two memset() calls being done on a user address
(about lines 879 and 904)
I've fixed the first and XXX'ed the others.
David Laight: firstname.lastname@example.org