Subject: Re: part 1 of lwp id in ktrace patches.
To: Darren Reed <>
From: Jason R Thorpe <>
List: tech-kern
Date: 03/10/2003 07:57:35
On Tue, Mar 11, 2003 at 02:29:36AM +1100, Darren Reed wrote:

 > If anyone wants to review the patches, you can find them at:

Stuff like:

! #ifdef KTRACE
! #ifdef        KTRACE gratuitous (and even incorrect, according to the style guide :-)
Please revert such whitespace changes before committing the patch.

You included a diff for sys/arch/i386/include/Makefile; I assume that was
in error?  Same with sys/arch/x86/include/Makefile.  Same with

All your added uses if LIST_FIRST(&p->p_lwps) need to be replaced with
correct code before this patch is committed.

You added cn_lwp, but kept cn_proc.  Seems like you should be able to
eliminate cn_proc.

Also note that since there is a major kernel interface change involved
here, you will need to bump the kernel version when this gets checked in.

        -- Jason R. Thorpe <>