Subject: Re: redundant defines?
To: D'Arcy J.M. Cain <darcy@NetBSD.org>
From: Jason R Thorpe <thorpej@wasabisystems.com>
List: tech-kern
Date: 03/09/2003 09:10:00
On Sun, Mar 09, 2003 at 09:38:55AM -0500, D'Arcy J.M. Cain wrote:

 > Any reason why we don't drop the #ifdef blocks here in 
 > src/sys/kern/syscalls.c?

syscalls.c is an automatically-generated file.  Changing the script
to remove some of the redundant #ifdefs would add complexity to that
script for basically no gain; there's no harm in leaving them there.

 > 
 > ...
 > "compat_43_olseek", /* 19 = compat_43 olseek */
 > #ifdef COMPAT_43
 >     "getpid",           /* 20 = getpid */
 > #else
 >     "getpid",           /* 20 = getpid */
 > #endif
 >     "mount",            /* 21 = mount */
 >     "unmount",          /* 22 = unmount */
 >     "setuid",           /* 23 = setuid */
 > #ifdef COMPAT_43
 >     "getuid",           /* 24 = getuid */
 > #else
 >     "getuid",           /* 24 = getuid */
 > #endif
 >     "geteuid",          /* 25 = geteuid */
 > ...
 > 
 > -- 
 > D'Arcy J.M. Cain <darcy@netbsd.org>
 > http://www.NetBSD.org/

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>