Subject: Re: [source-changes] CVS commit: src/sys/ufs/lfs
To: None <email@example.com>
From: Konrad Schroder <firstname.lastname@example.org>
Date: 02/18/2003 16:57:19
On Tue, 18 Feb 2003 email@example.com wrote:
> It's important to keep the source tree building... But, how is it
> even remotely possible to think that the change below is the right
> solution to the problem?!
Hm ... it is certainly the smallest solution to the problem, since "struct
lfs" is not shared between kernel and userland (only "struct dlfs" is);
but struct lfs and macros that depend on it are used by both.
Now, you could argue that userland doesn't need to use struct lfs, and
you'd probably be right, but if I had had the sense to "./build.sh
release" one last time, and noticed this error, I probably would have
adopted exactly this fix for it.
(What tripped this, I think, is that libsa includes code for booting LFS
that uses struct lfs. While it does not detract from your point in any
way, I do find it somewhat ironic that you wrote said LFS boot code :^)