christos@zoulas.com (Christos Zoulas) writes:

> >For 1), I think cache_lookup() should remove the entry if it returns
> >-1.
> 
> Do you mean remove the entry if v_id is not found, and keep the entry
> if the vnode cannot be locked?

I meant both case (v_id mismatch and vget() failure).  Is it worth to
leave positive cache entry when vget() failed?

BTW, if we take latter solution for the 2) below, we can leave this as
is.

> >For 2), I can imagine two fix.  one is to introduce new function to
> >remove cache entry and call it where appropriate in addition to
> >cache_purge().  The other is to lookup an existing entry in
> >cache_enter() and reuse it if there is.  I prefer the latter.
> 
> I think I prefer the latter too.

enami.