Subject: Re: bounds checking RAW_PART [was: Re: CVS commit: src/sys/dev]
To: Christoph Badura <bad@bsd.de>
From: Jason R Thorpe <thorpej@wasabisystems.com>
List: tech-kern
Date: 01/26/2003 16:21:07
On Mon, Jan 27, 2003 at 01:15:39AM +0100, Christoph Badura wrote:

 > No Unix that I've used in the last 20 years has done this and I've never
 > had a need to read beyond the end of the raw partition.  And if I suddenly
 > felt that urge, I'd simply change the disklabel to include more sectors.
 > There's nothing that prevents you from doing that.
 > 
 > Note also that a number of drivers has been bounds checking RAW_PART forever
 > and nobody seems to complain.

I have no problem with bounds-checking RAW_PART.  But it should not be
done with bound_check_with_label().  That function is desinged to bounds-
check against the disklabel.  RAW_PART is not to be checked against the
disklabel.  That is my only objection.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>