Subject: Re: inet_makeaddr(), u_long, _POSIX_SOURCE macro
To: Jaromir Dolecek <jdolecek@netbsd.org>
From: Jason R Thorpe <thorpej@wasabisystems.com>
List: tech-kern
Date: 01/05/2003 15:27:40
On Sun, Jan 05, 2003 at 05:48:38PM +0100, Jaromir Dolecek wrote:

 > We can't change it to in_addr_t (that would be ABI change for
 > 64bit archs, since in_addr_t is 32bit). But it would probably
 > be good to change the u_long to 'unsigned long' in the header.

Actually, it would not *really* be an ABI change, since all such
platforms pass those arguments in registers, and so they would
be zero-extended to 64-bits wide anyhow.

But, the real issue is that POSIX does not have an inet_makeaddr(),
and so defining _POSIX_SOURCE and then using inet_makeaddr() in your
program is incorrect.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>