Subject: Re: Request for review on scsipi changes
To: James Chacon <jchacon@genuity.net>
From: Manuel Bouyer <bouyer@antioche.eu.org>
List: tech-kern
Date: 09/16/2002 22:32:23
On Mon, Sep 16, 2002 at 01:28:44PM -0400, James Chacon wrote:
> [...]
> Attached are patches that do #2. Of the 2 sides to scsipi only the scsi end
> needed this as atapi doesn't have this problem. To account for "jitter" and
> to make sure all devices always attach in the same order a queue is used to
> force all probes to occur in bus attach order.

Looks good to me.
Maybe there's a chance to make the 2s SCSI delay before probe global instead
of per-channel ? It's annoying when you have a lot of channels.
The problem is that we have to keep it for hot-plug SCSI adapters.
I think the mechanism you implemented can help, with a global flag
set in scsibusattach() and cleared at the first SCSI_DELAY.

-- 
Manuel Bouyer <bouyer@antioche.eu.org>
--