On Fri, Aug 23, 2002 at 08:48:01AM +1200, Gregory McGarry wrote:

 > The MI implementation can be found here:
 > 
 > 	ftp://ftp.netbsd.org/pub/NetBSD/misc/gmcgarry/
 > 
 > Includes support for mips, m68k and i386.  The man pages discuss
 > most of the issues.  Would appreciate comments before moving forward.

Looks good, at first read-through.  The only comment I have so far
is that the splhigh()/splx() when holding p_raslock seems unnecessary;
I don't see where the p_raslist is accessed from an interrupt context.

Also, in the rasctl(2) page, the final store would be somwhere around
addr+len, but addr+len itself would be outside the RAS :-)  I guess the
intent is clear, though.

Thanks a million for working on this!

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>