Subject: Re: Adding video mode info to struct wsscreen_descr
To: TAKEMURA Shin <takemura@netbsd.org>
From: Bang Jun-Young <junyoung@mogua.com>
List: tech-kern
Date: 07/10/2002 11:19:02
On Wed, Jul 10, 2002 at 11:11:37AM +0900, TAKEMURA Shin wrote:
> From: Jason R Thorpe <thorpej@wasabisystems.com>
> Subject: Re: Adding video mode info to struct wsscreen_descr
> Date: Tue, 9 Jul 2002 07:38:26 -0700
> 
> > On Tue, Jul 09, 2002 at 07:21:37PM +0900, Bang Jun-Young wrote:
> > 
> >  > Some of you may know that I have been working on raster graphics
> >  > mode VGA driver and Mach64 framebuffer driver for some time. In order
> >  > to make video mode switching cleaner and simpler on those drivers,
> >  > I'd like to add a new member to struct wsscreen_descr. See below:
> > 
> > How about just a "void *modecookie" or something that points to an
> > object that is opaque to wscons itself?  Why does wscons need to know
> > about the dot clock, etc?  Only the VGA support routines need to know
> > about that.
> 
> I think you can freely add any members to struct wsscreen_descr like 
> below. Or you can retreive your mode data searching with 'name' member
> of struct wsscreen_descr, which shuld be identical.

Yes, but that's a quick hack and can't be a real solution in the
long run. I think "void *" cookie would be best, as of now.

Jun-Young

-- 
Bang Jun-Young <junyoung@mogua.com>