Subject: Re: Adding video mode info to struct wsscreen_descr
To: Noriyuki Soda <soda@sra.co.jp>
From: Bang Jun-Young <junyoung@mogua.com>
List: tech-kern
Date: 07/10/2002 01:08:27
On Tue, Jul 09, 2002 at 11:44:07PM +0900, Noriyuki Soda wrote:
> >>>>> On Tue, 9 Jul 2002 07:38:26 -0700,
> 	Jason R Thorpe <thorpej@wasabisystems.com> said:
> 
> > How about just a "void *modecookie" or something that points to an
> > object that is opaque to wscons itself?  Why does wscons need to know
> > about the dot clock, etc?  Only the VGA support routines need to know
> > about that.
> 
> Even if modecookie is used as opaque type from wscons related
> routines, "struct video_modetiming" is better than "void *",
> because compiler can check its type with the former.
> 
> Only "struct video_modetiming;" (rather than "#include <dev/ic/vidmode.h>")
> is needed in wscons related source files for the opaque case.

`mode' is a pointer of struct video_modetiming and has fixed size. No 
forware reference would be necessary there. <vidmode.h> should be included
where struct video_modetiming are actually used. 

Jun-Young

-- 
Bang Jun-Young <junyoung@mogua.com>