Subject: Re: wd.c patch to reduce kernel stack usage
To: None <david@l8s.co.uk>
From: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
List: tech-kern
Date: 06/27/2002 20:33:35
From: David Laight <david@l8s.co.uk>
Subject: Re: wd.c patch to reduce kernel stack usage
Date: Thu, 27 Jun 2002 12:21:50 +0100
> > like this?
> 
> 	generally....
> 
> > 		buf = wdperror(wd->drvp, wd->sc_wdc_bio.r_error);
> 	...
> >  		diskerr(bp, "wd", buf ? buf : "nomem" , LOG_PRINTF,
> >  		    wd->sc_wdc_bio.blkdone, wd->sc_dk.dk_label);
> 
> Would simplify things a bit.

it's wrong. see the code above it.
        case TIMEOUT:
                errbuf = "device timeout";
                goto retry;
and "nomem" isn't error of disk. :)

---
YAMAMOTO Takashi<yamt@mwd.biglobe.ne.jp>