--SUOF0GtieIMvvwua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

[Please do not CC me on responses to posts I've made on a mailing
list unless I ask for it. I procmail to keep extra things *out* of
my main mailbox, not because I'm going to ignore the mailing list
Thanks.]

On Mon, Jun 10, 2002 at 10:22:24AM -0700, Greywolf wrote:
> Der Mouse already has such a patch.

Against current sources?

> 	if (i->refcount > 0) {
> 		reconnect(i);
> 		adjust_link_count(i);
> 	}
>=20
> to
>=20
> 	if ((refcount > 0) || zflag) {
> 		reconnect(i);
> 		adjust_link_count(i);
> 	}
>=20
> Unless I'm really missing the boat on this one; I think I'm close enough
> to at least smack my face on its gunwales as I leap haplessly from the
> pier...

Might want to get to the ship on time. At the least, you really do
need to be reference i->refcount not just refcount (though I think
that's just a typo). More importantly, I think your logic's bad (if
zflag is what I think it is, you want an &&), but I haven't read
the contextual source code (and I'm a little busy to do so right
now).

> In NO WAY am I trying to dismiss the complexity of the code; perhaps
> "trivial" and "context" don't mix.  Sorry if I'm out of line on this.

Probably the best thing to do is to make your changes locally, try
it, and submit a patch when you've got something that fixes your
problem.

--=20
gabriel rosenkoetter
gr@eclipsed.net

--SUOF0GtieIMvvwua
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (NetBSD)

iD8DBQE9BQAK9ehacAz5CRoRAkXmAJ0TZgw7rQ0rXf8c+YuvifopjB9GyQCdHfEs
wyl4WfzcktaP3BS1jPtJTTY=
=hol9
-----END PGP SIGNATURE-----

--SUOF0GtieIMvvwua--