Subject: Re: Patch review for mouse console support
To: R. C. Dowdeswell <email@example.com>
From: Lennart Augustsson <firstname.lastname@example.org>
Date: 05/07/2002 10:36:27
Roland Dowdeswell wrote:
> On 1020245700 seconds since the Beginning of the UNIX epoch
> Julio Merino wrote:
> >Well, and the patch: http://jmmv.dyndns.org/NetBSD/mouse-patch.diff
> >I'm waiting your comments :)
> Quick comment is that this patch as it stands will break on a lot
> of arches GENERIC kernel because you extend struct wsdisplay_accessops.
> Of course, that's a minor niggle but you will want to give a heads
> up that the change will break a few things so that people know to
> fix them.
It doesn't have to break anything. If you extend the struct at the end and
all the code is able to handle 0 in the new fields things will work fine.