Subject: Re: CVS commit: [nathanw_sa] syssrc/sys/arch/m68k
To: Steve Woodford <scw@netbsd.org>
From: Jason R Thorpe <thorpej@wasabisystems.com>
List: tech-kern
Date: 11/25/2001 07:45:34
On Sun, Nov 25, 2001 at 12:39:36PM +0200, Steve Woodford wrote:

 > Modified Files:
 > 	syssrc/sys/arch/m68k/include [nathanw_sa]: mcontext.h
 > 	syssrc/sys/arch/m68k/m68k [nathanw_sa]: sig_machdep.c
 > 
 > Log Message:
 > When restoring thread context, check the _UC_USER bit and DTRT when
 > checking frame format and fpu saved state.
 > 
 > The whole `full fpu state cannot be saved/restored from userland' needs
 > more thought.
 > 
 > XXX: _UC_USER really ought to be defined in <sys/ucontext.h> ...

Ugh.  This is wrong.  _UC_USER is private to libpthread because it's
performing a libpthread-specific optimization.  If you really can't
implement it correctly in userland, then _getcontext_u(), _setcontext_u(),
and _swapcontext_u() should probably just aliases for the system calls
of similar names.

-- 
        -- Jason R. Thorpe <thorpej@wasabisystems.com>