Subject: Re: Adding new kernel configs (was: CVS commit: syssrc/sys/arch/i386/conf)
To: None <tech-kern@netbsd.org>
From: Bernd Ernesti <netbsd@arresum.inka.de>
List: tech-kern
Date: 08/11/2001 20:31:36
On Sat, Jul 07, 2001 at 01:44:46PM -0400, Michael Richardson wrote:
> 
> >>>>> "Bernd" == Bernd Ernesti <netbsd@arresum.inka.de> writes:
>     Bernd> On Fri, Jul 06, 2001 at 09:00:51PM +0300, Michael Richardson
>     Bernd> wrote:
>     >> Module Name: syssrc Committed By: mcr Date: Fri Jul 6 18:00:50 UTC
>     >> 2001
>     >> 
>     >> Added Files: syssrc/sys/arch/i386/conf: ARMADA
>     >> 
>     >> Log Message: new config file for M700 notebook with Cardbus and CBII
>     >> support
> 
>     Bernd> Hmm, why are you adding a second kernel config for a notebook?
> 
>   Because ARMADAs do not boot with CARDBUS kernel.

Then add a comment with what needs to be changed to the CARDBUS kernel
and remove the ARMADA kernel config.

>     Bernd> Isn't CARDBUS enough? From looking at a diff between the two, it
>     Bernd> looks like you even used the CARDBUS config as a base for the new
>     Bernd> one.
> 
>     Bernd> I thought we are trying to keep the number of kernel config as low
>     Bernd> as possible.
> 
>   Yes, I agree.
>   We should use cinclude and friends perhaps.

No, we should have fewer kernel config and add comments where needed.

>     Bernd> Another problem is that the kernel config files are getting out of
>     Bernd> sync. You added a comment and even a new driver which wasn't added
>     Bernd> to the other kernel configs.
> 
>   I should have called it "CBII", I guess. 

Please remove it and add a comment to the CARDBUS kernel config.

Bernd