Subject: Re: vop_symlink and unused vpp?
To: Assar Westerlund <>
From: Bill Studenmund <>
List: tech-kern
Date: 07/19/2001 12:42:02
On 19 Jul 2001, Assar Westerlund wrote:

> Bill Studenmund <> writes:
> > 
> >          * (Assumes that the lower layer always returns
> >          * a VREF'ed vpp unless it gets an error.)
> > 
> > i.e. we always get passed a &vp - we never pass in NULL - and the lower fs
> > always fills one in if it doesn't return an error.
> Currently it doesn't.  Both vop_mknod and vop_symlink can choose to
> return NULL, and their other callers are aware of that.  Should we
> change that to require them to return a locked vnode or an error?

Not sure. I can see arguments to permitting NULL to be returned, and
arguements to not permitting it be returned. As a tie breaker, what does
FreeBSD do?

My instinct is we probably should return the node always.

Take care,