Subject: Re: vop_symlink and unused vpp?
To: Konrad Schroder <email@example.com>
From: Assar Westerlund <firstname.lastname@example.org>
Date: 07/17/2001 10:18:23
Konrad Schroder <email@example.com> writes:
> > a) document that VOP_SYMLINK always gets *a_vpp = NULL in and can
> > choose to set it or not, but that it should be vrefed if != NULL. ufs
> > can always set it, thereby making lfs happy
> > b) remove it, and let lfs call a special ufs function instead of the
> > vnode operation
> > c) fix existing file systems to return the created vnode in a_vpp
> Any of these alternatives look fine to me, and perhaps (b) just means
> inlining ufs_symlink into lfs_symlink.
I was actually thinking of adding a ufs_symlink_internal that would
get called by both lfs_symlink and ufs_symlink.
> (a) is the easiest, being just a
> doc change, without any associated code changes, right?
No, to make the vpp return argument useful, it has to be refered, so
that would require changes to the filesystems returning vpp and to the
callers of VOP_SYMLINK.