Subject: Re: vop_symlink and unused vpp?
To: Assar Westerlund <firstname.lastname@example.org>
From: Bill Studenmund <email@example.com>
Date: 07/16/2001 14:38:50
On 16 Jul 2001, Assar Westerlund wrote:
> Konrad Schroder <firstname.lastname@example.org> writes:
> > LFS uses it; if it didn't exist, lfs_symlink would have to inline
> > ufs_symlink in order to know whether the symlink succeeded or not, so it
> > could know whether it had to take VDIROP off of a vnode or not.
> I see. And lfs cannot just check the return value from ufs_symlink
> since it might have created the node and then failed to write the
> contents of the symlink into a disk block.
> a) document that VOP_SYMLINK always gets *a_vpp = NULL in and can
> choose to set it or not, but that it should be vrefed if != NULL. ufs
> can always set it, thereby making lfs happy
Sounds the best to me.