Subject: Re: pciide_machdep_compat_intr_establish()
To: Jason R Thorpe , Simon Burge <email@example.com>
From: Chris Gilbert <firstname.lastname@example.org>
Date: 06/04/2001 00:01:24
On Sunday 03 June 2001 3:46 am, Jason R Thorpe wrote:
> On Sun, Jun 03, 2001 at 12:27:39PM +1000, Simon Burge wrote:
> > The pciide_machdep_compat_intr_establish() only does something on
> > ~half the ports that use pciide. The following patch makes it's use
> > conditional on having __HAVE_PCIIDE_MACHDEP_COMPAT_INTR_ESTABLISH
> > defined in <machine/pci_machdep.h>
> > I tested this on an alpha pc164 (which uses the function) and
> > cross-built (but not ran) a macppc kernel (which doesn't use the
> > function).
> > Comments?
> This looks great to me.
Only one comment, on the arm platforms (arm32 and netwinder) the define
should be in sys/arch/arm/pci_machdep.h, not in the arm32 and netwinder dirs,
other than that looks ok.