Subject: Re: patch for memory leak
To: Ted U <grendel@heorot.stanford.edu>
From: Bill Studenmund <wrstuden@zembu.com>
List: tech-kern
Date: 05/03/2001 12:36:13
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--0-1285192812-988918573=:515
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Thu, 3 May 2001, Ted U wrote:

> following is a patch that fixes 3 occurences of realloc in BSD kernels
> that could result in a memory leak.  if realloc returns null, then the
> previously held memory is not freed.  the affected areas are ipfilter and
> usb audio.

Thanks. I'll let Darren deal w/ the ip_fil.c change to reduce code
divergence.

I've made a tweaked version of your uadio changes. Your patch preserved
what I think was a mis-feature of the old code. If we fail to realloc, we
throw away all of the existing whatevers we were trying to realloc. I
think it'd be better to just keep the existing ones and have the add fail.

Take care,

Bill

--0-1285192812-988918573=:515
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=diffie
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.NEB.4.21.0105031236130.515@candlekeep.home-net.internetconnect.net>
Content-Description: New patch
Content-Disposition: attachment; filename=diffie

SW5kZXg6IHVhdWRpby5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1Mg
ZmlsZTogL2N2c3Jvb3Qvc3lzc3JjL3N5cy9kZXYvdXNiL3VhdWRpby5jLHYN
CnJldHJpZXZpbmcgcmV2aXNpb24gMS40MQ0KZGlmZiAtdSAtcjEuNDEgdWF1
ZGlvLmMNCi0tLSB1YXVkaW8uYwkyMDAxLzAxLzIzIDE0OjA0OjEzCTEuNDEN
CisrKyB1YXVkaW8uYwkyMDAxLzA1LzAzIDE5OjQyOjI1DQpAQCAtNTQxLDE0
ICs1NDEsMTcgQEANCiB1YXVkaW9fbWl4ZXJfYWRkX2N0bChzdHJ1Y3QgdWF1
ZGlvX3NvZnRjICpzYywgc3RydWN0IG1peGVyY3RsICptYykNCiB7DQogCWlu
dCByZXM7DQorCXN0cnVjdCBtaXhlcmN0bCAqb2xkX2N0bHMgPSBOVUxMOw0K
IA0KIAlpZiAoc2MtPnNjX25jdGxzID09IDApDQogCQlzYy0+c2NfY3RscyA9
IG1hbGxvYyhzaXplb2YgKm1jLCBNX1VTQkRFViwgTV9OT1dBSVQpOw0KIAll
bHNlDQotCQlzYy0+c2NfY3RscyA9IHJlYWxsb2Moc2MtPnNjX2N0bHMsIA0K
KwkJc2MtPnNjX2N0bHMgPSByZWFsbG9jKG9sZF9jdGxzID0gc2MtPnNjX2N0
bHMsIA0KIAkJCQkgICAgICAoc2MtPnNjX25jdGxzKzEpICogc2l6ZW9mICpt
YywNCiAJCQkJICAgICAgTV9VU0JERVYsIE1fTk9XQUlUKTsNCiAJaWYgKHNj
LT5zY19jdGxzID09IE5VTEwpIHsNCisJCWlmIChvbGRfY3RscykNCisJCQlz
Yy0+c2NfY3RscyA9IG9sZF9jdGxzOw0KIAkJcHJpbnRmKCJ1YXVkaW9fbWl4
ZXJfYWRkX2N0bDogbm8gbWVtb3J5XG4iKTsNCiAJCXJldHVybjsNCiAJfQ0K
QEAgLTEwMjIsMTMgKzEwMjUsMTcgQEANCiB2b2lkDQogdWF1ZGlvX2FkZF9h
bHQoc3RydWN0IHVhdWRpb19zb2Z0YyAqc2MsIHN0cnVjdCBhc19pbmZvICph
aSkNCiB7DQorCXN0cnVjdCBhc19pbmZvICpvbGRfYWx0cyA9IE5VTEw7DQor
DQogCWlmIChzYy0+c2NfbmFsdHMgPT0gMCkNCiAJCXNjLT5zY19hbHRzID0g
bWFsbG9jKHNpemVvZiAqYWksIE1fVVNCREVWLCBNX05PV0FJVCk7DQogCWVs
c2UNCi0JCXNjLT5zY19hbHRzID0gcmVhbGxvYyhzYy0+c2NfYWx0cywNCisJ
CXNjLT5zY19hbHRzID0gcmVhbGxvYyhvbGRfYWx0cyA9IHNjLT5zY19hbHRz
LA0KIAkJCQkgICAgICAoc2MtPnNjX25hbHRzKzEpICogc2l6ZW9mICphaSwN
CiAJCQkJICAgICAgTV9VU0JERVYsIE1fTk9XQUlUKTsNCiAJaWYgKHNjLT5z
Y19hbHRzID09IE5VTEwpIHsNCisJCWlmIChvbGRfYWx0cykNCisJCQlzYy0+
c2NfYWx0cyA9IG9sZF9hbHRzOw0KIAkJcHJpbnRmKCJ1YXVkaW9fYWRkX2Fs
dDogbm8gbWVtb3J5XG4iKTsNCiAJCXJldHVybjsNCiAJfQ0K
--0-1285192812-988918573=:515--