matt debergalis wrote:
> Added Files:
> 	syssrc/sys/smbfs: Makefile smbfs.h smbfs_io.c smbfs_ioctl.c
> 	    smbfs_node.c smbfs_node.h smbfs_smb.c smbfs_subr.c smbfs_subr.h
> 	    smbfs_vfsops.c smbfs_vnops.c
> 
> Log Message:
> initial stab at smbfs (CIFS).  originally for freebsd by boris popov,
> first ported to 1.4 branch by Christian Limpach <chris@nice.ch>.

Great :)

Though, this should have been done that the original FreeBSD version would
be cvs imported, and NetBSD changes would be committed separately.
First and foremost, the NetBSD specific changes are localized and
it would be easy to sync with FreeBSD changes. Second, it would
make the process of feeding back NetBSD changes to FreeBSD much easier. 

I'd also preferred if the thing (commit of smbfs support) was discussed
first. There might be some architectural issues which should
have been solved before commit - like I think netsmb code should
be in under smbfs, it's not adding different network stack (or is it ?).

Re: iconv vs. codeconv - I'm not actively working on codeconv ATM.  So it's
probably OK to use the FreeBSD iconv for now. It would be nice to discuss
features of iconv API and possibly make the routines common to
filesystems which need file name recoding engine (ntfs, Joliet
cd9660, msdosfs). But this is separate issue from smbfs.

Jaromir
-- 
Jaromir Dolecek <jdolecek@NetBSD.org>      http://www.ics.muni.cz/~dolecek/
@@@@  Wanna a real operating system ? Go and get NetBSD, damn!  @@@@