Subject: Re: uvm_km_valloc_align() and USPACE (Re: CVS commit: syssrc)
To: Izumi Tsutsui <>
From: Jason R Thorpe <>
List: tech-kern
Date: 11/30/2000 10:42:02
On Fri, Dec 01, 2000 at 03:34:36AM +0900, Izumi Tsutsui wrote:

 > > s/NBPG/PAGE_SIZE/ please.
 > Currently, USPACE on all ports (except sparc/sparc64) defined
 > as (UPAGES * NBPG). Should these be fixed, too?

If it's in machdep code, NBPG is "okay".  But we should be purging NBPG
from MI code -- we already have PAGE_SIZE, which properly deals with
different page sizes on systems that have that issue (e.g. SPARC).

 > I guess USPACE_ALIGN is cpu specific, but we don't have
 > powerpc/include/vmparam.h nor m68k/include/vmparam.h.
 > Are these files needed?

I think so, and we should move as many of the common constants into those
files as possible.

        -- Jason R. Thorpe <>