At Fri, 15 Sep 2000 08:56:47 -0700,
Erik E. Fair <fair@clock.org> wrote:
> 
> cc  -O2 -Werror -Wall -Wstrict-prototypes -Wmissing-prototypes 
> -Wpointer-arith -Wno-uninitialized
> -Wno-main -mno-fp-regs -I. -I/usr/src/sys/arch -I/usr/src/sys 
> -nostdinc -DDIAGNOSTIC -DLKM -DMAXUSE
> RS=32 -D_KERNEL -Dalpha  -c /usr/src/sys/dev/usb/ucom.c
> cc1: warnings being treated as errors
> /usr/src/sys/dev/usb/ucom.c: In function `tiocm_to_ucom':
> /usr/src/sys/dev/usb/ucom.c:645: warning: comparison is always 0 due 
> to limited range of data type
> /usr/src/sys/dev/usb/ucom.c:647: warning: comparison is always 0 due 
> to limited range of data type
> *** Error code 1
> 
> Stop.

Sorry.  It has been fixed in rev. 1.29 of ucom.c.

While looking through the code, I noticed almost all of
tiocm_to_xxxx()s' definitions use int in their second arguments.

I think these functions also should be converted to use u_long.
Is there a reason to use int?  (If there is, it might be necessary to
back out rev. 1.29.)

--
IWAMOTO Toshihiro