Subject: Re: lf_advlock() API change
To: =?iso-8859-1?Q?Jarom=EDr_Dole=E8ek?= <dolecek@ibis.cz>
From: Jason R Thorpe <thorpej@zembu.com>
List: tech-kern
Date: 07/21/2000 08:35:54
On Fri, Jul 21, 2000 at 01:47:20PM +0200, Jaromír Doleček wrote:
> Hi,
> I'd like to change kernel lk_advlock() from current
>
> int lf_advlock __P((struct lockf **,
> off_t, caddr_t, int, struct flock *, int));
>
> to
>
> int lf_advlock __P((struct vop_advlock_args *, struct lockf **, u_quad_t));
What's the u_quad_t at the end? Is that really off_t? If so, it should say
off_t :-)
>
> This matches common usage and also gives added bonus of beeing
> FreeBSD-compatible.
>
> Thoughs ? I'd like to pullup this change to 1.5 branch as well.
>
> Jaromir
> --
> Jaromir Dolecek <jdolecek@NetBSD.org> http://www.ics.muni.cz/~dolecek/
> @@@@ Wanna a real operating system ? Go and get NetBSD, damn! @@@@
>
--
-- Jason R. Thorpe <thorpej@zembu.com>