To: Jason Thorpe <>
From: None <>
List: tech-kern
Date: 02/07/2000 11:25:40
> > This is why the sysctl to control it is there - people who don't want 
> > it can turn it off. The default to on for DIAGNOSTIC was based on my 
> > interpretation of DIAGNOSTIC as "I want more checks and information" 
> > and it seemed reasonable to me. Do I misread the intent of DIAGNOSTIC?
>Well, if nothing else, it's certainly a misuse of DIAGNOSTIC.  DIAGNOSTIC
>is for "cheap kernel consistency checks", not for "extra verbose logging
>when broken user programs are run".
>The sysctl default value should NOT key off DIAGNOSTIC.

	I intend to correct several misuse of DIAGNOSTIC (ipprintfs in 
	ip_input.c, some of IPv6 DAD and gif code), which one looks most right?
	- use log(LOG_DEBUG), not printf()
	- #ifdef DEBUG
	- something else