Subject: Re: Cardbus
To: None <email@example.com>
From: Hayakawa Koichi <firstname.lastname@example.org>
Date: 12/21/1999 10:06:25
From: Lennart Augustsson <email@example.com>
Date: Tue, 21 Dec 1999 01:50:54 +0100
> * make the code KNF (this is easy, I can do that).
Please do that.
# I feel 8 columns for each indentation is too big.
> * make card eject work. Maybe it works for others, but not on my
> Vaio 505TX and I'm soon desperate for hot swapping cards.
Now, network card can be detached?
> * remove calls to delay(). There should NO calls to delay for
> periods longer than a few microseconds, perhaps 100 if you're
> desperate. Busy wait is evil. (I think the PCMCIA code still
> calls delay() for long periods from the interrupt routine!)
I have a test code no to use delay() in thread context. But
at the boottime (before kernel thread wake up), delay()
should be used. This test code is based on NetBSD-1.4L.