Subject: Re: VOP_FSYNC parameter extension
To: Todd Whitesel <email@example.com>
From: Frank van der Linden <firstname.lastname@example.org>
Date: 12/13/1999 10:54:35
On Fri, Dec 10, 1999 at 06:52:13PM -0800, Todd Whitesel wrote:
> >> So, I'd like to add to parameters to VOP_FSYNC: start (off_t) and end (off_t).
> > I would suggest using start and len instead so you don't need to worry
> > about handling cases where end < start.
> Good idea, especially if you also define len==0 to mean "all".
> Any time I see a conceptually unsigned argument using a -1 value
> for anything, I get this vague uneasy feeling...
I don't quite see the point in this. After all, sanity checks are
needed anyway. If offset and length is used, you'll have to check
if len < 0, etc.
off_t is supposed to be signed; it's used for things like relative
seeks, so that's not a point I worry about either.