Subject: Re: codeset recoding engine
To: Christos Zoulas <christos@zoulas.com>
From: Jaromir Dolecek <dolecek@ics.muni.cz>
List: tech-kern
Date: 11/13/1999 17:04:42
Christos Zoulas wrote:
> codeset_get()? maybe

Agreed.

> codeset_unicode_getc()? maybe
> codeset_unicode_gets()? maybe

Yeah, those would probably make sense. Thanks :)

> Why does it return ssize_t? Can it fail?

Yes, it can fail if the length of target string is not long enough
This case is not thoroughly tested in unicode_convert_string() though.
Note that even fs code often doesn't check, if the name is not longer
than available buffer (at least msdosfs doesn't check).

> It also the order of the
> arguments should be (dst, src) instead of (src, dst) like most other
> routines.

Indeed.

Jaromir
-- 
Jaromir Dolecek <jdolecek@NetBSD.org>      http://www.ics.muni.cz/~dolecek/
"It's IMPOSSIBLE to overcomment any code. It can only be undercommented."
@@@ Wanna a real operating system ? Go and get NetBSD, damn it! @@@