Subject: Re: KNF for i386 pmap new?
To: None <chuck@ccrc.wustl.edu>
From: Simon Burge <simonb@netbsd.org>
List: tech-kern
Date: 05/05/1999 23:33:05
chuck@ccrc.wustl.edu wrote:
> > Is there a reason why the i386 version of pmap-new is not KNF'd? I just
> > had a look at Chuck's resident count changes and noticed this...
>
> >chuck doesn't like KNF.
>
> [note this refers to me rather than Chuck S.]
>
> while it is true that i do not like KNF, i have no problem with my code
> in the tree being converted to KNF so that it matches everything else.
> matt volunteered to convert the UVM code to KNF and i would guess that
> i386 pmap.new.c is just something that slipped through the cracks, so
> there is no need to get worked up about it.
As the original questioner, I'm not getting worked up at all. My main
beef was that "diff -up" didn't work :-). If it's a choice between good
code and funny styling, I'll take the good code any day!
Simon.