Subject: Re: CVS commit: src
To: Jason Thorpe <email@example.com>
From: Manuel Bouyer <firstname.lastname@example.org>
Date: 03/26/1999 10:18:50
On Thu, Mar 25, 1999 at 11:48:18AM -0800, Jason Thorpe wrote:
> On Thu, 25 Mar 1999 08:50:52 -0800 (PST)
> Manuel BOUYER <email@example.com> wrote:
> > Modified Files:
> > src/usr.bin/eject: eject.c
> > Log Message:
> > Use CDIOCEJECT instead of DIOCEJECT for cdrom devices (this one allows
> > opening the tray without media). While I'm there add 'sd' to the
> > device list (so that I can eject my MO easily).
> Why?! Why not just make the CD-ROM driver treat CDIOCEJECT and DIOCEJECT
> the same way?!
> I'd like to deprecate a bunch of those CDIOC ioctls.
Sorry, I did the wrong thing yesterday, and it doesn't even work (I only
tested the change with an empty drive :( (I noticed it after being back home)
DIOCEJECT is OK, the change needed was to not call DIOCLOCK before if we're
not doing a forcible eject, DIOCEJECT will check open partitions and
unlock the door if it can.
Please don't remember me I'm the one who did the changes to DIOCEJECT :)
Manuel Bouyer <firstname.lastname@example.org>