"Brett D. Slager" <bds@snarf.thnet.com> writes:
> Additional information that may be desired includes:
> 
> [ ... ]

> u_int	coresize;	/* fb core mmap size */
> u_int	fboff;		/* fb core memory offset */
> u_int	fbsize;		/* fb core memory size */
> u_int	regoff;		/* fb core registers offset */
> u_int	regsize;	/* fb core registers size */

These do not belong in this ioctl.  they should be expressed
indirectly by a bus_space() implementation in user space.  it should
be possible to map a device's multiple 'spaces' into user space.
further determining how those spaces correspond to video memory,
registers, etc., isn't nearly as simple as the "two regions" you
describe.


> @@ -194,7 +206,7 @@
>  	u_char	*green;				/* green color map elements */
>  	u_char	*blue;				/* blue color map elements */
>  };      
> -#define WSDISPLAYIO_GETCMAP	_IOW('W', 66, struct wsdisplay_cmap)
> +#define WSDISPLAYIO_GETCMAP	_IOR('W', 66, struct wsdisplay_cmap)
>  #define WSDISPLAYIO_PUTCMAP	_IOW('W', 67, struct wsdisplay_cmap)
>  
>  /* Video control.  Not applicable to all display types. */

This was not a bug, do not fix it.



cgd
-- 
Chris Demetriou - cgd@netbsd.org - http://www.netbsd.org/People/Pages/cgd.html
Disclaimer: Not speaking for NetBSD, just expressing my own opinion.