Subject: Re: CVS commit: src
To: None <firstname.lastname@example.org>
From: Jason Thorpe <email@example.com>
Date: 03/17/1999 10:08:14
On Wed, 17 Mar 1999 08:49:00 -0800 (PST)
Konrad Schroder <firstname.lastname@example.org> wrote:
> Module Name: src
> Committed By: perseant
> Date: Wed Mar 17 16:49:00 UTC 1999
> Modified Files:
> src/sys/ufs/lfs: lfs.h
> Log Message:
> Fix pad on lfs.h so it is really 512 bytes, as advertized
That reminds me...
The dlfs_cksum should be at the end of the superblock, not before the padding.
With it in its current position, if you ever end up using fields after
the checksum, either:
(a) they won't be checksummed, or
(b) you'll have to bump the fs level.
Given that the only thing that checks the checksum is your (not yet
checked in) fsck_lfs, perhaps now is the right time to move the checksum
to the end of the superblock, and put the pad in front of it.
-- Jason R. Thorpe <email@example.com>