Subject: Re: new TIODCDTIMESTAMP patch
To: Jonathan Stone <jonathan@dsg.stanford.edu>
From: Jason Thorpe <thorpej@nas.nasa.gov>
List: tech-kern
Date: 04/20/1998 16:34:07
On Mon, 20 Apr 1998 16:38:58 -0700 (PDT) 
 Jonathan Stone <jonathan@DSG.Stanford.EDU> wrote:

 > + 	case TIOCDCDTIMESTAMP:
 > + 		com->sc_dcd_timestamping = 1;
 > + 		*(struct timeval *)data = com->dcd_timestamp;
 > + 		break;

Actually, let me expand on that a little...

One of two things needs to happen here:

	(1) the driver must ALWAYS collect timestamps, and
	    TIOCDCDTIMESTAMP simply retrieves them, or

	(2) there needs to be two ioctls, one that enables/disables
	    timestamp collection, and one that actually retrieves the
	    timestamps.  If timestamps are not currently enabled,
	    an error needs to be retured indicating that there isn't
	    any timestamp to retrieve.

Jason R. Thorpe                                       thorpej@nas.nasa.gov
NASA Ames Research Center                            Home: +1 408 866 1912
NAS: M/S 258-5                                       Work: +1 650 604 0935
Moffett Field, CA 94035                             Pager: +1 415 428 6939