On Tue, 2 Sep 97 18:06:36 WET DST 
 Dave Huang <khym@bga.com> wrote:

 > Hi there... I'm working on integrating the FreeBSD udpates to the ncr
 > driver into NetBSD, and had a few questions...
 > 
 > FreeBSD has a "ncrreg.h" file, while NetBSD's version is named
 > "ncr_reg.h". Any objections to renaming NetBSD's to match FreeBSD's?

This sounds perfectly fine to me.  We can even preserve the revision history
when the file name changes.

 > Second question is... why are cmd, sbcl, delta, et al. in ncr_int_ma()
 > U_INT32s? In the FreeBSD code, they're u_char, except for delta, which
 > is a u_short.

Don't know for sure why they're 32-bit quantities, but at the very least,
you should be using fixed-size types, not "u_char".

Jason R. Thorpe                                       thorpej@nas.nasa.gov
NASA Ames Research Center                            Home: +1 408 866 1912
NAS: M/S 258-6                                       Work: +1 415 604 0935
Moffett Field, CA 94035                             Pager: +1 415 428 6939