Subject: Re: tsleep while cold can be avoided!
To: Gordon W. Ross <email@example.com>
From: Jason Thorpe <firstname.lastname@example.org>
Date: 03/25/1997 15:54:42
On Tue, 25 Mar 97 17:51:55 EST
email@example.com (Gordon W. Ross) wrote:
> I've since tried out the code movement idea, and it works very nicely!
> If I move the code that does: findroot/setroot, swapconf, dumpconf
> from where it is now into a new, separate function that is called just
> before vfs_mountroot, then the kernel does not call tsleep while cold.
> The code that I moved does things like read disk labels, and is more
> robust against missing interrupt problems if it is done later, so that
> timeouts will work. Therefore, I propose the following changes.
..the patch is straightforward enough.. and I agree 100% with your
rationale. I'd say "go for it" (i.e. make the appropriate change to
each port's autoconf.c, as well).
I also think that an #ifdef DIAGNOSTIC panic in tsleep if called
while cold would be appropriate. Also, if that is the only use
of "safepri", then we could kill it, too.
Jason R. Thorpe firstname.lastname@example.org
NASA Ames Research Center Home: 408.866.1912
NAS: M/S 258-6 Work: 415.604.0935
Moffett Field, CA 94035 Pager: 415.428.6939