Subject: Re: "esp" driver reorg proposal
To: Gordon W. Ross <gwr@mc.com>
From: Jason Thorpe <thorpej@nas.nasa.gov>
List: tech-kern
Date: 01/25/1997 14:26:52
On Sat, 25 Jan 97 16:58:24 EST
"Gordon W. Ross" <gwr@mc.com> wrote:
> Oops, oh yeah. OK then, how about
>
> dev/ic/espcommon.c
>
> or maybe the MD parts should be namd for their attachments, i.e.
>
> arch/alpha/tc/tc_esp.c
> arch/sparc/dev/sbus_esp.c
> arch/sun3x/dev/obio_esp.c
Ok... since it's going to live in sys/dev/ic... :-)
sys/dev/ic/ncr53c9x.c (note, lack of "esp" and "asc" :-)
sys/dev/ic/ncr53c9xreg.h
sys/dev/ic/ncr53c9xvar.h
sys/arch/alpha/tc/esp.c (not on tc; really on tcds)
sys/arch/sparc/dev/esp.c (multiple attachments in one file)
sys/arch/sun3x/dev/esp.c
I do _not_ like the notion of <machine/espvar.h>, or whatever. That
doesn't scale; perhaps you have some weird machine that has a 53c9x
on two very different busses... "oops!"
The functionality that is provided by the current macros in the header
files could be provided by function pointers.
I'd also like to see softc layering a'la the MI 5380 driver. (That
even allows ports to arbitrarily rename it :-)
Anyhow, this is more consistent with how MI chip drivers are currently
arranged, and we should be consistent.
Ciao.
Jason R. Thorpe thorpej@nas.nasa.gov
NASA Ames Research Center Home: 408.866.1912
NAS: M/S 258-6 Work: 415.604.0935
Moffett Field, CA 94035 Pager: 415.428.6939